v12: Convert all setup >>>-vars to @-vars #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In talking with @sshakoor1, he found that the
>>>FOO<<<bits ofgcm_setupand the use in other files were causing weird issues with Jinja in the Python conversion.But, as @rtodling has repeatedly reminded us on the GCM side,
@FOOare variables detemplated at setup time,>>>FOO<<<are at runtime. And we have been abusing/ignoring that. This PR fixes that.I'll do some testing, but I can't see how it can't work (beyond my making a typo).