Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Move FMS to Baselibs #368

Closed
wants to merge 38 commits into from
Closed

WIP: Move FMS to Baselibs #368

wants to merge 38 commits into from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 26, 2022 •
edited
Loading

This PR tracks an effort to move FMS to Baselibs.

Needed tags:

(Note that CI will fail badly until I can make some Docker images with FMS in Baselibs. But I'm waiting to make sure it'll build/run on discover.)

Current testing with FMS 2024.01 shows this is non-zero-diff. At C24, it seems like it isn't but at C720 it is fully NZD.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff labels Jan 26, 2022
@mathomp4 mathomp4 self-assigned this Jan 26, 2022
@mathomp4 mathomp4 added the Contingent - DNA These changes are contingent on other PRs label Jan 26, 2022
@mathomp4
Copy link
Member Author

Closes #369

@mathomp4 mathomp4 linked an issue Jan 26, 2022 that may be closed by this pull request
Update FMS and move FMS to Baselibs #369
Open
@mathomp4 mathomp4 removed the Non 0-diff The changes in this pull request are non-zero-diff label Feb 18, 2022
@mathomp4 mathomp4 mentioned this pull request Sep 19, 2022
Open
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@mathomp4
Merge branch 'main' into feature/mathomp4/fms-baselibs
fa0496f 
# Conflicts:
#	README.md
#	components.yaml
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@mathomp4 mathomp4 added Non 0-diff The changes in this pull request are non-zero-diff 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 6, 2023
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 10, 2024
@mathomp4 mathomp4 mentioned this pull request May 10, 2024
Merged
@mathomp4 mathomp4 removed the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 13, 2024
@mathomp4
Copy link
Member Author

I am closing this as @sdrabenh has taken FMS-in-Baselibs to our v12 codebase in #785

@mathomp4 mathomp4 closed this Jun 10, 2024
@mathomp4 mathomp4 deleted the feature/mathomp4/fms-baselibs branch June 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mathomp4 mathomp4

Labels
Contingent - DNA These changes are contingent on other PRs Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update FMS and move FMS to Baselibs
1 participant
@mathomp4