Updates to use FMS in Baselibs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
0 diff
sanAkel
approved these changes
May 10, 2024
|
@sanAkel Note that I hope we can get this in and tagged soon. So I guess something for you to think on: Should this be Ocean v2.2? Or maybe v3.0? I mean, the only change is: Now requires new FMS...but that is a big requirement! |
@mathomp4 I already approved it. Merge it when you want to. As for the version number, we can get to that when making a new release (next step While you are at the ocean, can you please update mom6 fork - if outdated. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for when GEOS moves to FMS 2024.01. In doing so, we move to FM2 infrastructure rather than ye olde FMS1. (cc @sanAkel)
Note I'm marking this as both zero-diff and non-zero-diff because...it's weird. See GEOS-ESM/GEOSgcm#368 for more info but it's like a couple fields are different, but barely so and it doesn't seem to affect anything else.