v11: Add dependency to fms_r4 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dependency to
fms_r4. We need this because of the weird way we build FV3 as r4 but link to the r8 version of FMS. In that case, we still need to point to the include files from r4 FMS.But, CMake in that case has no idea that to build, say, Moist, that we need to build
fms_r4before building this.NOTE NOTE NOTE
This change is NOT needed in GEOSgcm v12 because in that case FMS is in Baselibs/Spack and so CMake doesn't need to know. I've added a big fat comment for the inevitable case when a merge to v12 happens and the build fails.