Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic): remove unneeded logic in parsing semver-like versions #277

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

G-Rath
Copy link
Owner

@G-Rath G-Rath commented Oct 31, 2024

While I'm a little reluctant to do this as I'm sure I included these for a reason, they're apparently not covered by any tests and the longer they remain the more likely someone might start actually depending on them.

I'm pretty sure the bulk of this was present as part of having semantic rebuild the parsed version for debugging when I was writing the implementation, but that's not actually a feature so we don't explicitly need to be doing it - this won't stop us from reintroducing the logic in future if we decide we want it

@G-Rath G-Rath merged commit 674b62d into main Oct 31, 2024
12 checks passed
@G-Rath G-Rath deleted the semantic/remove-unneeded-logic branch October 31, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant