Added default llm name to the config #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Jan 28, 2025
llmclient/llms.py
Outdated
| if "config" not in data: | ||
| data["config"] = {} | ||
| if "name" in data and "model_list" not in data["config"]: | ||
| if "name" not in data: | ||
| data["name"] = data["config"].get("name", CommonLLMNames.GPT_4O.value) |
There was a problem hiding this comment.
Suggested change
| data["name"] = data["config"].get("name", CommonLLMNames.GPT_4O.value) | |
| data["name"] = data["config"].get("name", cls.model_fields["name"].default) |
Can we do something like this, to avoid the repetition?
There was a problem hiding this comment.
Thanks! I tried cls.name and it didn't work. Will try the model_fields
7 tasks
jamesbraza
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the default
LiteLLMModel.namewas not actually being used. NotLiteLLMModel.config['model_list']is correctly populated if the used creates the llm withLiteLLMModel()Also, if only a config is passed (
LiteLLMModel(config=config)), it checks if there's a name inside the config to be used.