Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] [MODDING] Several QOL modding changes #3979

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Kade-github
Copy link
Contributor

@Kade-github Kade-github commented Jan 7, 2025

Does this PR close any issues? If so, link them below.

N/A

Briefly describe the issue(s) fixed.

This is a merged PR of my previous ones that contain all of my recent modding changes.

This PR contains:

  • USE_CUSTOM_RENDER_DISTANCE:Bool, and CUSTOM_RENDER_DISTANCE_MS:Float in Strumline.hx to allow for custom render distances.
  • customVertexData:Bool, setIndices(indices:Array<Int>):Void, setVertices(vertices:Array<Float>):Void, and setUVTData(uvtData:Array<Float>):Void in SustainTrail.hx to allow for custom hold note vertices, uvs, and indicies.
  • Updates onSongRetry to onSongRetry(event:SongRetryEvent):Void which now contains a difficulty:String field. This allows scripts to react to difficulty changes.
  • showNotesplash:Bool into Strumline.hx. This will allow for scripts to disable note splashes on a song-by-song basis, and later for the game to add a notesplash setting.

Include any relevant screenshots or videos.

image

Song retry event for pausesubstate.hx
Song retry event for playstate.hx
Song retry event for stage.hx
Song retry event for bopper.hx
Song retry event for song.hx
Scripted class event
Module event
@github-actions github-actions bot added large A large pull request with more than 100 changes haxe Issue/PR modifies game code and removed large A large pull request with more than 100 changes labels Jan 7, 2025
Copy link
Contributor

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vertex stuff would be really fun to experiment with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants