Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Numerous Stage Editor Bugs fixed #3671

Closed
wants to merge 7 commits into from
Closed

[BUGFIX] Numerous Stage Editor Bugs fixed #3671

wants to merge 7 commits into from

Conversation

KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented Oct 12, 2024 •
edited
Loading

Does this PR close any issues? If so, link them below.

  1. Fixes a crash regarding saving Stages, referenced here
  2. Fixes images being cleared after a stage is saved (not referenced anywhere)
  3. Fixes the selection shader being present even during the mode being "Characters" (not referenced anywhere)
  4. Fixes the issue of pasted objects not having any animations

i didnt actually change the docs, dunno why thats there i recently updated the branch, weird

@github-actions github-actions bot added medium A medium pull request with 100 or fewer changes haxe Issue/PR modifies game code documentation Issue/PR modifies documentation or README files labels Oct 12, 2024
@Stompyyyy
Copy link

p-peak

@biomseed
Copy link

biomseed commented Oct 12, 2024 •
edited
Loading

p-peak

No no, it's just beginning. It's only going to get better from here

@Stompyyyy
Copy link

true

@KoloInDaCrib
Fix More AssetDataHandler.hx Stuff
75fb2ab 
i forgot things to fix for the data.bitmap not being null, oops!
@KoloInDaCrib
Update AssetDataHandler.hx
0ad02e4
@KoloInDaCrib
one super small change to StageDataHandler.hx
147d03d 
basically made it split the names of objects to get rid of da slash,,,,,,,,
@KoloInDaCrib
revert last commit
360c492 
for i am an idiot
@KoloInDaCrib KoloInDaCrib mentioned this pull request Jan 4, 2025
Open
@KoloInDaCrib KoloInDaCrib deleted the stage-editor-fix branch January 4, 2025 21:08
@biomseed
Copy link

biomseed commented Jan 8, 2025

why close this?

@Hundrec
Copy link
Contributor

Hundrec commented Jan 8, 2025

Check out #3974 for Kolo's explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Issue/PR modifies documentation or README files haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KoloInDaCrib @Stompyyyy @biomseed @Hundrec @EliteMasterEric