Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use beta-5 wallet connector UI #41

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Use beta-5 wallet connector UI #41

merged 7 commits into from
Feb 22, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Feb 21, 2024

This shouldn't be merged until the wallet is live on the chrome extension store. The beta-5 wallet is now live!

This PR updates the playground to work with the new beta-5 wallet. It also uses the new useConnectUI hook that provides a modal for selecting which wallet to connect with, and has installation links.

Screencap

This is showing it working with the dev wallet, but now that the beta-5 wallet is available, it works with the official wallet too.

Feb-21-2024.16-14-46.mp4

To test locally

Run cd app && npm i && npm start

@sdankel sdankel requested review from a team February 21, 2024 00:58
@sdankel sdankel changed the title Use beta-5 wallet connectors Use beta-5 wallet connector UI Feb 22, 2024
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work thanks for doing this!

@sdankel sdankel merged commit c6ade36 into master Feb 22, 2024
9 checks passed
@sdankel sdankel deleted the sophie/beta-5-wallet branch February 22, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants