Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet calculate gas performance #1794

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

feat: wallet calculate gas performance #1794

wants to merge 30 commits into from

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Jan 22, 2025 •
edited
Loading

Summary

  • Centralized provider logic, avoid recreating provider instances for the same network url
  • Sped up account balance calculation by making requests in parallel
  • Sped up gas calculation by using fee data recently generated by Send Machine in the Send Machine -> Tx Request Machine flow (i.e. Send screen).
  • Sped up gas calculation in SendMachine and TxRequestMachine by using already present information on account/balance from accountMachine instead of re-fetching
  • Sped up gas calculation in SendMachine and TxRequestMachine by merging calculations of default tip and gas limit into a single parallelized promise.
  • Decrease unnecessarily long delay in tx and send machines while waiting for a possible new user input

@arthurgeron arthurgeron changed the title improve: wallet calculate gas performance feat: wallet calculate gas performance Jan 24, 2025
@arthurgeron arthurgeron marked this pull request as ready for review January 24, 2025 21:29
@arthurgeron arthurgeron marked this pull request as draft January 24, 2025 21:29
@arthurgeron arthurgeron marked this pull request as ready for review January 24, 2025 23:02
LuizAsFight
LuizAsFight requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createProvider can return as it was before

LuizAsFight
LuizAsFight requested changes Jan 27, 2025
View reviewed changes
packages/app/src/systems/DApp/machines/transactionRequestMachine.tsx Outdated Show resolved Hide resolved
packages/app/src/systems/Send/machines/sendMachine.ts Outdated Show resolved Hide resolved
packages/app/src/systems/Send/machines/sendMachine.ts Outdated Show resolved Hide resolved
packages/app/src/systems/Transaction/services/transaction.tsx Outdated Show resolved Hide resolved
packages/app/src/systems/DApp/machines/transactionRequestMachine.tsx Outdated Show resolved Hide resolved
packages/app/src/systems/Transaction/services/transaction.tsx Outdated Show resolved Hide resolved
packages/app/src/systems/Transaction/services/transaction.tsx Outdated Show resolved Hide resolved
packages/app/src/systems/Transaction/services/transaction.tsx Show resolved Hide resolved
packages/app/src/systems/Transaction/services/transaction.tsx Show resolved Hide resolved
.changeset/young-laws-flash.md Outdated Show resolved Hide resolved
@arthurgeron arthurgeron marked this pull request as draft January 27, 2025 23:02
@arthurgeron arthurgeron force-pushed the ag/feat/fe-808 branch 2 times, most recently from 757536d to 74fdb4a Compare January 27, 2025 23:27
@arthurgeron arthurgeron marked this pull request as ready for review January 28, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

@nelitow nelitow Awaiting requested review from nelitow nelitow is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve performance of transaction approval from dapp
2 participants
@arthurgeron @LuizAsFight