Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NFTs loading state #1786

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add NFTs loading state #1786

wants to merge 3 commits into from

Conversation

kirtiraj22
Copy link

Resolves #1779

Changes

  • Added a loading state to the NFT tab

GIF :

nft-loading

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Jan 20, 2025

Thanks for the contribution! Before we can merge this, we need @kirtiraj22 to sign the Fuel Labs Contributor License Agreement.

@kirtiraj22 kirtiraj22 force-pushed the feat/add-nft-loading-state branch from 641fd78 to 1918c82 Compare January 20, 2025 19:00
@helciofranco
Copy link
Member

Hey @kirtiraj22 thanks for your contribution.

Could you please sign that CLA and update with master branch?

@helciofranco helciofranco changed the title Feat/add nft loading state feat: add NFTs loading state Jan 27, 2025
@helciofranco
Copy link
Member

Oh, we also need a changeset for it.

You can run pnpm changeset and follow the steps (it will generate a file that you should commit)

@kirtiraj22
Copy link
Author

hey @helciofranco I’ve added a changeset and updated my branch with the latest master changes.
Let me know if there’s anything else to address!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron arthurgeron is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

@nelitow nelitow Awaiting requested review from nelitow nelitow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add loading state to NFT tab
2 participants
@kirtiraj22 @helciofranco