Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to submit a list of changes to rocksdb #2619

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Jan 22, 2025

Description

The goal of this PR is to allow to insert a list of changes instead of one HashMap of changes. This avoid multiple update produced by different threads for example, to be merged in one transaction.

By removing this step we remove a whole iteration and insert/deletion in a big HashMap of changes.

It's currently not used anywhere in the code but you can see a usage example here : #2618

In this PR when we have to write history modifications we are still merging the changes in one big transaction before calling store_modifications_history because I don't think it's possible to use this algorithm with changes splitted in different parts. @acerone85 if you have an idea I would be happy to here it but in any case I think this should go to follow-up PR to not overcharge this one. (I made an attempt in branch try_adapt_history_vec branch but it's mehhh)

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT self-assigned this Jan 22, 2025
@AurelienFT AurelienFT added the xxx label Jan 22, 2025
@AurelienFT AurelienFT marked this pull request as ready for review January 23, 2025 14:12
@AurelienFT AurelienFT requested a review from acerone85 January 23, 2025 14:12
@AurelienFT AurelienFT marked this pull request as draft January 23, 2025 15:14
@AurelienFT
Copy link
Contributor Author

Works but draft until mature enough to fit requirements of : #2618

@AurelienFT AurelienFT marked this pull request as ready for review January 24, 2025 13:51
@AurelienFT AurelienFT requested a review from a team January 24, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant