Set Latest Recorded Height on startup #2603
Conversation
| let starting_recorded_height = match self.gas_price_db.get_recorded_height()? { | ||
| Some(height) => height, | ||
| None => { | ||
| let mut storage_tx = self.gas_price_db.begin_transaction()?; |
There was a problem hiding this comment.
Where do you commit this transaction? Also, maybe it makes sense to allow customization of the gas price height from CLI? For example: you want to sync with the network from genesis block, but you only want to calculate the gas price starting the latest block height, to avoid huge debt because data was not posted during previous blocks.
There was a problem hiding this comment.
Where do you commit this transaction?
Hmm. I'll double check that it makes sense. I got the test to pass so I assumed it was okay but you're right. Might be able to move this to the sync section.
Also, maybe it makes sense to allow customization of the gas price height from CLI?
Yeah. I think that's a good idea.
We can add this too. I like the idea. It just wasn't blocking. |
|
|
Just went ahead and did #2613 too while waiting. |
| @@ -85,6 +85,7 @@ pub struct Config { | |||
| /// The size of the memory pool in number of `MemoryInstance`s. | |||
| pub memory_pool_size: usize, | |||
| pub da_gas_price_factor: NonZeroU64, | |||
| pub starting_recorded_height: Option<u32>, | |||
There was a problem hiding this comment.
You can work directly with BlockHeight
| type Wrapper<'a> | ||
| = FuelStorageUnrecordedBlocks<&'a mut Self> | ||
| where | ||
| Self: 'a; |
There was a problem hiding this comment.
Just curious about this. Caused by an update to fmt?
## Version v0.41.1 * fault_proving(compression): include block_id in da compressed block headers by @rymnc in #2551 * chore: Add myself and Andrea as codeowner for graphql API + related crates by @netrome in #2570 * fix(integration_tests): remove flake from produce_block__l1_committed_block_affects_gas_price by @rymnc in #2566 * bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis better by @MitchTurner in #2599 * Fix version compatibility error by @AurelienFT in #2608 * Improve error messages for responses from committer by @MitchTurner in #2609 * Update async processor tests by @rafal-ch in #2577 * The amount of returned dust coins is limited by factor relative to the amount of selected big coins by @rafal-ch in #2610 * fix(da_compression): invalid decompression of utxo id and CoinConfig fix by @rymnc in #2593 * Use latest gas price to estimate next price for tx pool checks by @MitchTurner in #2612 * Set Latest Recorded Height on startup by @MitchTurner in #2603 * Use latest gas price to estimate next block gas price during dry runs by @MitchTurner in #2615 * Check that fuel-core lib builds correctly without default features by @rafal-ch in #2594 * Expose indexation status in `NodeInfo` endpoint by @rafal-ch in #2595 **Full Changelog**: v0.41.0...v0.41.1
Linked Issues/PRs
closes #2613
Description
This improves the behavior for debugging the code--for long-running sessions it won't change anything. If this isn't set on. startup, it will be delayed each time you restart the node unless it runs long enough to receive DA costs. These changes persists the expectations from the first run.
Checklist