bugfix: Improve the BlockCommitterHttpApi client to use url apis better
#2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
changed the title
BlockCommitterHttpApi client to use url apis betterBlockCommitterHttpApi client to use url apis better
rymnc
reviewed
Jan 20, 2025
Comment on lines
+134
to
+135
| let path = format!("/v1/costs?variant=specific&value={l2_block_number}&limit={NUMBER_OF_BUNDLES}"); | ||
| let full_path = url.join(&path)?; |
There was a problem hiding this comment.
what path was it constructing previously?
There was a problem hiding this comment.
I was getting "//v1".
AurelienFT
previously approved these changes
Jan 20, 2025
rymnc
previously approved these changes
Jan 20, 2025
xgreenx
reviewed
Jan 20, 2025
| if let Some(url) = &self.url { | ||
| tracing::debug!("getting da costs by l2 block number: {l2_block_number}"); | ||
| let formatted_url = format!("{url}/v1/costs?variant=specific&value={l2_block_number}&limit={NUMBER_OF_BUNDLES}"); | ||
| let response = self.client.get(formatted_url).send().await?; | ||
| let path = format!("/v1/costs?variant=specific&value={l2_block_number}&limit={NUMBER_OF_BUNDLES}"); |
There was a problem hiding this comment.
I think we have the same issue with SS service, could you also apply it there please?=D
AurelienFT
previously approved these changes
Jan 20, 2025
xgreenx
reviewed
Jan 20, 2025
| @@ -87,8 +88,10 @@ pub async fn estimate_transaction( | |||
| let request = SimulateRequest { | |||
| tx_bytes: tx_bytes.to_string(), | |||
| }; | |||
| let path = "/cosmos/tx/v1beta1/simulate"; | |||
There was a problem hiding this comment.
We have this problem in all requests=D
There was a problem hiding this comment.
Ah.. I just found the first one. Didn't look farther.
xgreenx
approved these changes
Jan 21, 2025
AurelienFT
approved these changes
Jan 21, 2025
Merged
MitchTurner
added a commit
that referenced
this pull request
Jan 22, 2025
## Version v0.41.1 * fault_proving(compression): include block_id in da compressed block headers by @rymnc in #2551 * chore: Add myself and Andrea as codeowner for graphql API + related crates by @netrome in #2570 * fix(integration_tests): remove flake from produce_block__l1_committed_block_affects_gas_price by @rymnc in #2566 * bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis better by @MitchTurner in #2599 * Fix version compatibility error by @AurelienFT in #2608 * Improve error messages for responses from committer by @MitchTurner in #2609 * Update async processor tests by @rafal-ch in #2577 * The amount of returned dust coins is limited by factor relative to the amount of selected big coins by @rafal-ch in #2610 * fix(da_compression): invalid decompression of utxo id and CoinConfig fix by @rymnc in #2593 * Use latest gas price to estimate next price for tx pool checks by @MitchTurner in #2612 * Set Latest Recorded Height on startup by @MitchTurner in #2603 * Use latest gas price to estimate next block gas price during dry runs by @MitchTurner in #2615 * Check that fuel-core lib builds correctly without default features by @rafal-ch in #2594 * Expose indexation status in `NodeInfo` endpoint by @rafal-ch in #2595 **Full Changelog**: v0.41.0...v0.41.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
Before we were just building a String from the
Urltype, rather than using its apis. That was bad and this is more robust. I feel like it could be more precise than this, but I'm not finding a better way looking at theurldocs.