feat(gas_price_service_v1): include max_da_gas_price to control volatility
#2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
chore/max-da-gas-price
branch
from
0108782 to
4fd0ee2
Compare
MitchTurner
reviewed
Jan 8, 2025
| @@ -540,6 +548,12 @@ impl AlgorithmUpdaterV1 { | |||
| .saturating_mul(self.gas_price_factor.into()) | |||
| } | |||
|
|
|||
| fn max_scaled_da_gas_price(&self) -> u64 { | |||
| // note: here we make sure that a correct maximum is used; hacky :( | |||
| max(self.max_da_gas_price, self.min_da_gas_price + 1) | |||
There was a problem hiding this comment.
Probably can just use min_da_gas_price without the + 1, but maybe there is a weird edge case I missing.
Comment on lines
+523
to
+527
| max( | ||
| self.min_scaled_da_gas_price(), | ||
| maybe_new_scaled_da_gas_price, | ||
| ), | ||
| self.max_scaled_da_gas_price(), |
There was a problem hiding this comment.
Let's add some tests for this.
MitchTurner
reviewed
Jan 8, 2025
crates/fuel-gas-price-algorithm/src/v1/tests/update_da_record_data_tests.rs
Outdated
Show resolved
Hide resolved
Voxelot
reviewed
Jan 8, 2025
Co-authored-by: Brandon Kite <[email protected]>
…data_tests.rs Co-authored-by: Mitchell Turner <[email protected]>
rymnc
force-pushed
the
chore/max-da-gas-price
branch
from
7ad61f7 to
261045f
Compare
MitchTurner
approved these changes
Jan 9, 2025
rymnc
merged commit ae40ee4
into
chore/add-tests-for-v1-gas-service
51 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
Adds a new config param
max_da_gas_price, whichnew_scaled_da_gas_pricedepends upon while mutating it.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]