Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment Charts #35

Merged
merged 13 commits into from
Aug 15, 2023
Merged

Deployment Charts #35

merged 13 commits into from
Aug 15, 2023

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Jul 27, 2023

Adds helm configuration to deploy the block committer to k8s

@rfuelsh rfuelsh linked an issue Jul 28, 2023 that may be closed by this pull request
Deploy Fuel Block Commiter Helm Chart #34
Closed
@rfuelsh rfuelsh requested review from rfuelsh, liviudm and tirkesi July 28, 2023 02:14
liviudm
liviudm suggested changes Jul 28, 2023
View reviewed changes
deployment/charts/templates/deploy.yaml Show resolved Hide resolved
deployment/charts/templates/deploy.yaml Outdated Show resolved Hide resolved
deployment/charts/templates/deploy.yaml Outdated Show resolved Hide resolved
deployment/charts/templates/deploy.yaml Show resolved Hide resolved
deployment/charts/templates/deploy.yaml Show resolved Hide resolved
deployment/charts/templates/deploy.yaml Outdated Show resolved Hide resolved
deployment/scripts/.env Show resolved Hide resolved
deployment/scripts/.env Show resolved Hide resolved
@Voxelot Voxelot marked this pull request as ready for review August 7, 2023 21:04
@Voxelot Voxelot requested a review from liviudm August 7, 2023 21:04
@Voxelot
Copy link
Member Author

Voxelot commented Aug 7, 2023

@liviudm I updated all the places where there could be ambiguity in the labels to use the helm chart Release.Name. Since helm guarantees there can only be one release name per namespace, this ensures that in the event that two committers are deployed to the same namespace there won't be any confusion for things like the ServiceMonitor or NodePort.

This was referenced Aug 8, 2023
Closed
Open
Voxelot
Voxelot commented Aug 8, 2023
View reviewed changes
deployment/scripts/.env Outdated Show resolved Hide resolved
@Voxelot Voxelot merged commit 9df2afb into master Aug 15, 2023
@mchristopher mchristopher deleted the Voxelot/helm-chart branch August 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuelsh rfuelsh Awaiting requested review from rfuelsh

@tirkesi tirkesi Awaiting requested review from tirkesi

@liviudm liviudm Awaiting requested review from liviudm

Assignees

@Voxelot Voxelot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy Fuel Block Commiter Helm Chart
2 participants
@Voxelot @liviudm