Challenge tabs #90
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import type { Comment } from '../../../types/types'; | ||
| import { ReactComponent as Reply } from '/components/icons/reply.svg'; | ||
| import { ReactComponent as Liked } from '/components/icons/liked.svg'; | ||
| import { getTimeDiffFromTimestamp } from 'utils/timeDifference/getTimeDiffFromTimestamp'; | ||
| import { UserAvatar } from 'molecules/userAvatar/userAvatar'; | ||
|
|
||
| type CommentItemWithReplyProps = Comment; | ||
|
|
||
| export const CommentReply = ({ | ||
| avatar, | ||
| author, | ||
| timestamp, | ||
| comment, | ||
| }: CommentItemWithReplyProps) => { | ||
| // TODO: Add reply functionality | ||
| return ( | ||
| <> | ||
| <hr className="my-2 ml-16 border-gray-200" /> | ||
| <div className="flex flex-row pt-1 md-10 md:ml-16"> | ||
| <UserAvatar avatar={avatar} size={12} /> | ||
| <div className="flex-col mt-1"> | ||
| <div className="flex items-center flex-1 px-4 font-bold leading-tight"> | ||
| {author} | ||
| <span className="ml-2 text-xs font-normal text-gray-500"> | ||
| {getTimeDiffFromTimestamp(timestamp)} | ||
| </span> | ||
| </div> | ||
| <div className="flex-1 px-2 ml-2 text-sm font-medium leading-loose text-gray-600"> | ||
| {comment} | ||
| </div> | ||
| <button className="inline-flex items-center px-1 pt-2 ml-1 flex-column"> | ||
| <div className="w-5 h-5"> | ||
| <Reply /> | ||
| </div> | ||
| </button> | ||
| <button className="inline-flex items-center px-1 -ml-1 flex-column"> | ||
| <div className="w-5 h-5"> | ||
| <Liked /> | ||
|
There was a problem hiding this comment. This buttons with icons are a good candidate for a separate component as well ;) |
||
| </div> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import Image from 'next/image'; | ||
| import clsx from 'clsx'; | ||
|
|
||
| type CommentUserAvatarProps = { | ||
| avatar: string; | ||
| size?: number; | ||
| }; | ||
|
|
||
| export const UserAvatar = ({ avatar, size = 24 }: CommentUserAvatarProps) => { | ||
| const sizeClass = `w-${size} h-${size}`; | ||
| return ( | ||
| <Image | ||
| alt="" | ||
| src={avatar} | ||
ssynowiec marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| width={1000} | ||
| height={1000} | ||
| className={clsx( | ||
| 'object-cover border-2 border-gray-300 rounded-full', | ||
| sizeClass, | ||
| )} | ||
| /> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make a
comment: Commentprop accepting an object. No need for spreading then and you have everything contained in one objectThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but you neeed to destructure it later or write redundant object prop calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have a param destructurization than something like that tbh.
As for now the
CommentItemPropsis redundant as the props could be directly typed asComment.I used to spread props but over the time I learned in most of the cases it is better to explicitly pass props. There are some exceptions ofc (for example
registerfunction for form libs)