Skip to content

Commit

Permalink
GH Actions: PHP 8.4 has been released
Browse files Browse the repository at this point in the history
* Builds against PHP 8.4 are no longer allowed to fail.

Ref: https://www.php.net/releases/8.4/en.php
  • Loading branch information
jrfnl committed Nov 22, 2024
1 parent 52c764f commit 72b4293
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
- '8.4'

name: "PHP: ${{ matrix.php }}"
continue-on-error: ${{ matrix.php == '8.4' }}

steps:
- name: Checkout code
Expand All @@ -71,15 +70,8 @@ jobs:

# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-composer-dependencies
- name: "Install Composer dependencies (PHP < 8.4)"
if: ${{ matrix.php < '8.4' }}
uses: "ramsey/composer-install@v2"

- name: "Install Composer dependencies (PHP 8.4)"
if: ${{ matrix.php >= '8.4' }}
- name: "Install Composer dependencies"
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-reqs

- name: Run unit tests
run: composer test
Expand Down

0 comments on commit 72b4293

Please sign in to comment.