New CI with Github Actions #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you need to install SuiteSparse explicitly when building PETSc? Can't you let PETSc install it? Also, there are a couple of parallel packages in the sequential installs (ParMmg, ParMETIS, to name a few). |
|
Bien vu, I stupidly copy paste former tests. I'm not completely familiar with all the dependencies, can you confirm that I didn't leave anything uselss? |
prj-
reviewed
Dec 21, 2024
|
Thanks ;) |
simonlegrand
force-pushed
the
slegrand-actions
branch
3 times, most recently
from
e100e87 to
6c11b37
Compare
prj-
reviewed
Jan 17, 2025
| @@ -260,7 +267,7 @@ sub downloadone{ | |||
| system $cmd; | |||
| if($?){ | |||
| print "Download failed from $url of $pkg\n"; | |||
| my $url="https://www.ljll.fr/hecht/pkg/$pkg"; | |||
| my $url="https://joliv.et/freefem/pkg/$pkg"; | |||
There was a problem hiding this comment.
It seems the dependencies download problems have been solved by this fix. I'd keep it if it's ok for you.
- Don't seem to impact CI directly - Most appear to be formatting changes
Each workflow contents several jobs (Debug/Release + plateforms)
simonlegrand
force-pushed
the
slegrand-actions
branch
from
6c11b37 to
69d7895
Compare
|
|
Three previous comments fixed in 92027eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first contribution to the new FreeFem CI.
5 different configurations of FreeFem are tested:
Each of these workflows contains jobs for Debug and Release and different combinations of platforms.
Currently, the build step doesn't work for the following configuration:
But most of the tests should fail because of the removal of the
continue-on-error: trueat themake checkstep (few tests fail for almost each config). It can be temporarily put back if you prefer.At first, if you prefer to merge on a different branch, just add the branch name in the
Finally, due to the particular development workflow (push to test), the commit history is particularly dirty and should probably be squashed before the merge. It can be retrieved here
Cheers,
Simon