Independent keyboard shortcuts for Labels and Folders. (#259)

* Changed to "l" for Labels and "v" for Folders in Gmail. * Updated gitignore to ignore build files.
Foundry376 · Oct 28, 2017 · bb2b78a · bb2b78a
1 parent 475203a
commit bb2b78a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -68,3 +68,7 @@ client_secret.json
 /app/dist-docs
 /app/mailsync.dSYM.zip
 /snap/snapcraft.yml
+
+**.so*
+**.bin
+**.tar.gz
diff --git a/app/internal_packages/category-picker/lib/label-picker.cjsx b/app/internal_packages/category-picker/lib/label-picker.cjsx
@@ -33,7 +33,7 @@ class LabelPicker extends React.Component
     @_account = AccountStore.accountForItems(nextProps.items)
 
   _keymapHandlers: ->
-    "core:change-category": @_onOpenCategoryPopover
+    "core:change-labels": @_onOpenCategoryPopover
 
   _onOpenCategoryPopover: =>
     return unless @props.items.length > 0
@@ -59,7 +59,7 @@ class LabelPicker extends React.Component
         globalMenuItems={[
           {
             "label": "Thread",
-            "submenu": [{ "label": "Apply Labels...", "command": "core:change-category", "position": "endof=thread-actions" }]
+            "submenu": [{ "label": "Apply Labels...", "command": "core:change-labels", "position": "endof=thread-actions" }]
           }
         ]}
         >

diff --git a/app/internal_packages/category-picker/lib/move-picker.cjsx b/app/internal_packages/category-picker/lib/move-picker.cjsx
@@ -33,7 +33,7 @@ class MovePicker extends React.Component
     @_account = AccountStore.accountForItems(nextProps.items)
 
   _keymapHandlers: ->
-    "core:change-category": @_onOpenCategoryPopover
+    "core:change-folders": @_onOpenCategoryPopover
 
   _onOpenCategoryPopover: =>
     return unless @props.items.length > 0
@@ -58,7 +58,7 @@ class MovePicker extends React.Component
         globalMenuItems={[
           {
             "label": "Thread",
-            "submenu": [{ "label": "Move to Folder...", "command": "core:change-category", "position": "endof=thread-actions" }]
+            "submenu": [{ "label": "Move to Folder...", "command": "core:change-folders", "position": "endof=thread-actions" }]
           }
         ]}
         >

diff --git a/app/internal_packages/preferences/lib/tabs/keymaps/displayed-keybindings.js b/app/internal_packages/preferences/lib/tabs/keymaps/displayed-keybindings.js
@@ -15,7 +15,8 @@ module.exports = [
       ['core:gmail-remove-from-view', 'Gmail Remove from view'],
       ['core:star-item', 'Star'],
       ['core:snooze-item', 'Snooze'],
-      ['core:change-category', 'Change Folder / Labels'],
+      ['core:change-labels', 'Change Labels'],
+      ['core:change-folders', 'Change Folder'],
       ['core:mark-as-read', 'Mark as read'],
       ['core:mark-as-unread', 'Mark as unread'],
       ['core:mark-important', 'Mark as important (Gmail)'],

diff --git a/app/keymaps/templates/Gmail.json b/app/keymaps/templates/Gmail.json
@@ -36,7 +36,8 @@
 
   "core:mute-conversation": "m",
   "core:focus-search": "/",
-  "core:change-category": ["l", "v"],
+  "core:change-labels": "l",
+  "core:change-folders": "v",
   "core:focus-toolbar": ",",
   "core:star-item": "s",
   "core:gmail-remove-from-view": "y",