Skip to content

Commit

Permalink
Fix oauth code parsing, compsoer quoted text color in dark themes
Browse files Browse the repository at this point in the history
  • Loading branch information
bengotow committed Feb 6, 2018
1 parent aeec270 commit 27dcee2
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Improvements:

Fixes:

* On linux, the system tray icon is smaller (22x22 with 18x18 content vs 32x32)

* In dark themes, quoted text no longer appears a dark purple that is difficult to read.

* Mailspring no longer becomes "blocked" when ingesting a large number of deletions in a mailbox and will no longer attempt to retrieve many, many new messages all at once.

* When changing accounts in the composer the signature correctly updates to the new account's default. #570
Expand Down
4 changes: 2 additions & 2 deletions app/internal_packages/composer/styles/composer.less
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

.RichEditor-root blockquote {
border-left: 2px solid #eee;
color: #500050;
color: mix(@text-color, purple, 50%);
margin: 0;
padding: 0 0 0 10px;
-webkit-margin-after: initial !important;
Expand Down Expand Up @@ -56,7 +56,7 @@
}
}
blockquote {
color: #500050;
color: mix(@text-color, purple, 50%);
}
&:hover {
border: 1px dashed @border-color-divider;
Expand Down
10 changes: 4 additions & 6 deletions app/internal_packages/onboarding/lib/oauth-signin-page.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { shell, clipboard } from 'electron';
import { React, PropTypes } from 'mailspring-exports';
import { RetinaImg } from 'mailspring-component-kit';
import http from 'http';
import url from 'url';

import FormErrorMessage from './form-error-message';
import { LOCAL_SERVER_PORT } from './onboarding-helpers';
Expand Down Expand Up @@ -49,12 +50,9 @@ export default class OAuthSignInPage extends React.Component {
// launch a web server
this._server = http.createServer((request, response) => {
if (!this._mounted) return;
if (request.url.includes('code=')) {
let code = request.url.split('code=').pop();
if (code.endsWith('#')) {
code = code.substring(0, code.length - 1);
}
this._onReceivedCode(code);
const { query } = url.parse(request.url, { querystring: true });
if (query.code) {
this._onReceivedCode(query.code);
response.writeHead(302, { Location: 'https://id.getmailspring.com/oauth/finished' });
response.end();
} else {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 27dcee2

Please sign in to comment.