-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] [MIG] rma_reason_code #568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can remove 735847b Seems code from another module |
MeritxellAForgeFlow
force-pushed
the
17.0-mig-rma_reason_code
branch
from
December 18, 2024 10:31
e13a1d0
to
b17baa8
Compare
MiquelRForgeFlow
approved these changes
Dec 18, 2024
HviorForgeFlow
approved these changes
Dec 18, 2024
MeritxellAForgeFlow
force-pushed
the
17.0-mig-rma_reason_code
branch
from
December 18, 2024 11:51
b17baa8
to
27178f0
Compare
LoisRForgeFlow
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below
MeritxellAForgeFlow
force-pushed
the
17.0-mig-rma_reason_code
branch
from
December 19, 2024 08:20
27178f0
to
1802c71
Compare
LoisRForgeFlow
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
Depends on #529
@ForgeFlow