Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] rma_reason_code #568

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[17.0] [MIG] rma_reason_code #568

merged 3 commits into from
Dec 19, 2024

Conversation

MeritxellAForgeFlow
Copy link

@MeritxellAForgeFlow MeritxellAForgeFlow commented Dec 16, 2024

Migration to 17.0
Depends on #529

@ForgeFlow

@HviorForgeFlow
Copy link
Contributor

Can remove 735847b

Seems code from another module

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments below

rma_reason_code/models/reason_code.py Show resolved Hide resolved
rma_reason_code/views/rma_order_line_views.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now thanks!

@LoisRForgeFlow LoisRForgeFlow merged commit 37d0194 into 17.0 Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants