Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: update velodyne_cloud_separator.cpp with get_data() method #49

Merged
merged 1 commit into from
Jul 14, 2024
Merged

hotfix: update velodyne_cloud_separator.cpp with get_data() method #49

merged 1 commit into from
Jul 14, 2024

Conversation

Autumn60
Copy link
Collaborator

@Autumn60 Autumn60 commented Jul 14, 2024 •
edited
Loading

#41 マージ後に #47 が Update branch されないままレビューされたためmainに入り込んだバグを修正

@Autumn60 Autumn60 mentioned this pull request Jul 14, 2024
Merged
@Autumn60 Autumn60 requested a review from Bey9434 July 14, 2024 15:24
Bey9434
Bey9434 approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@Bey9434 Bey9434 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Autumn60 Autumn60 merged commit 6bf6644 into main Jul 14, 2024
3 checks passed
@RyodoTanaka
Copy link
Contributor

@Autumn60
いらん事してしまってすみません！
PRありがとうございますm(_ _)m

@Bey9434
レビューありがとうございました！

@Autumn60 Autumn60 deleted the hotfix/velodyne_cloud_separator/fix_function_name branch July 20, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bey9434 Bey9434 Bey9434 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Autumn60 @RyodoTanaka @Bey9434