Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ParameterSchedulers to 0.4, (keep existing compat) #162

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2024

This pull request changes the compat entry for the ParameterSchedulers package from 0.3.1 to 0.3.1, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ToucheSir ToucheSir closed this Feb 3, 2024
@ToucheSir ToucheSir reopened this Feb 3, 2024
Copy link
Contributor Author

github-actions bot commented Feb 3, 2024

A documentation preview has been successfully built, view it here: Documentation preview PR-162

@ToucheSir
Copy link
Member

This can't be merged as-is because somewhere is expecting Scheduler to be defined. Changes will either need to be made to FluxTraining or ParameterSchedulers before doing so.

@darsnack darsnack merged commit 2fa2fb3 into master Mar 9, 2024
7 of 13 checks passed
@darsnack darsnack deleted the compathelper/new_version/2024-02-03-01-00-27-780-02072116814 branch March 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants