-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps & bump to 0.16.1 #2574
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 32.50% 32.50%
=======================================
Files 34 34
Lines 2003 2003
=======================================
Hits 651 651
Misses 1352 1352 ☔ View full report in Codecov by Sentry. |
CI seems to get NNlib has errors FluxML/NNlib.jl#619 |
It's because of ComponentArrays used in tests. It needs a bump for UPD: Ah and optimisers as well. |
Ok, we are now picking Zygote 0.7.1 but there are some real failures |
I think conv failures should be fixed by FluxML/NNlib.jl#620 |
Now tests are not passing due to julia> m = Chain([Dense(3 => 4, tanh; bias=false), Dense(4 => 2)]);
julia> x = randn(Float32,3,5);
julia> y = rand(Bool,2,5);
julia> g = gradient(m -> Flux.logitcrossentropy(m(x), y), m)[1]
(layers = NamedTuple{(:weight, :bias, :σ)}[(weight = InplaceableThunk(ChainRules.var"#..., Thunk(ChainRules.var"#...)), bias = nothing, σ = nothing), (weight = Thunk(Zygote.var"#...), bias = Float32[-0.088241935, 0.088241935], σ = nothing)],) |
Maybe |
I wouldn't expect any thunk to appear in the output of Zygote.gradient as well, right? |
PR Checklist