multiplication of {Transpose, Adjoint} of Array and OneHotVector

[gxyd]

Also fixes #777 . Tests have been added.

[gxyd]

@mcabbott this is ready for a review.

[DhairyaLGandhi]

Looks good, thanks!

[CarloLucibello]

I think this is superseded by #1447. We should make sure that the tests added here get in there. Could merge this now, then #1447 should rebase and fix conflicts

[CarloLucibello]

Or we could wait for #1447 to be merged, then rebase this, and fix #777 if it is not fixed already

[gxyd]

Or we could wait for #1447 to be merged, then rebase this, and fix #777 if it is not fixed already

@CarloLucibello I think this solution sounds better, since that is a new way of implementation for the OneHot. I definitely don't mind if need be the code from this PR directly copied to the new OneHot implementation PR, so we directly fix it in that PR itself

[gxyd]

I'll keep this PR open? Since in case wearen't able to have new one-hot implementation ready for v0.12 , we can probably just think of this PR may be.

[DhairyaLGandhi]

Probably easier to merge this now since I'd like the tests in and rushing #1447 makes me uncomfortable since it makes strong decisions around using internal Julia functions and complicates its design

[darsnack]

Was this addressed by #1448 that superseded #1447? If so, we can close. Actually, looking more closely, I don't think #1447 or #1448 address the issue here? They both still only define *(::AbstractMatrix, ::OneHotArray) instead of the specific type wrappers in this PR.

[ToucheSir]

Bump? The new OneHotArray has been in a few stable releases now.

[darsnack]

@gxyd I hope you don't mind, I just rebased your PR (all the code is same and your authorship is preserved). I think this PR is good to go once the checks pass.

[gxyd]

@darsnack I'm glad the code written could be of some help.

[darsnack]

Thanks @gxyd!

[darsnack]

bors r+

[bors]

Build succeeded:

• buildkite/flux-dot-jl