fix: use setProperty instead of setAttribute for zoom property

[paodb]

Close #132

Summary by CodeRabbit

• Bug Fixes
  • Improved the zoom functionality in Google Maps by using a more efficient method to set the zoom level.

[coderabbitai]

Walkthrough

The GoogleMap class in the project was updated to modify the setZoom method. Instead of using setAttribute to set the zoom level, the method now uses setProperty. This change ensures consistency with how the getZoom method retrieves the zoom level, addressing an issue where getZoom always returned zero.

Changes

File Path	Change Summary
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java	Modified setZoom method to use setProperty instead of setAttribute

Sequence Diagram(s) (Beta)

No significant changes to control flow or new features that warrant a sequence diagram.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Ensure setZoom uses setProperty instead of setAttribute (#132)	✅
Verify getZoom returns the correct zoom level after setting it (#132)	✅

Poem

In the code of maps, a change so bright,
Zoom now sets with proper might.
No longer lost in attribute's night,
The zoom level's now just right.
Bugs are gone, the code's delight,
Maps now zoom with all their might!
🎉🐇✨

Warning

Review ran into problems

Problems (1)

• Git: Failed to clone repository. Please contact CodeRabbit support.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91c0b84 and b64a113.

Files selected for processing (1)

• src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1 hunks)

Additional comments not posted (2)

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (2)

122-122: Change from setAttribute to setProperty correctly aligns with the expected behavior of setting the zoom level as a property rather than an attribute. This should resolve the issue where getZoom was not retrieving the correct zoom level.

---

122-122: Please verify that the change in the setZoom method does not affect other functionalities that depend on the zoom property.

#!/bin/bash
# Description: Verify that no other functionalities are affected by the change in the `setZoom` method.

# Test: Search for other occurrences of the zoom property being set or retrieved.
rg --type java $'this.getElement().getProperty("zoom"'