Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug on no setting file #46

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix a bug on no setting file #46

merged 1 commit into from
Jan 31, 2025

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Jan 31, 2025

When a setting file does not exist, we unintentionally regarded the content as "404 Page not found", but we should regard it as an empty setting.

image

Test

  • Execute test\run-test-server\run-test-server-.bat
  • Remove test\run-test-server\congis\*.txt
  • Open Outlook
  • Open FlexConfirmMail setting dialog
  • Select "Configure Trusted Domains and Addresses" tab
    • Confirm that the template for no policy setting or only current user config are used.
    • Confirm that "404 Page not found" is not shown,
  • Select "Configure Unsafe Domains and Addresses" tab
    • Confirm that the template for no policy setting or only current user config are used.
    • Confirm that "404 Page not found" is not shown,
  • Select "Configure Unsafe Files" tab
    • Confirm that the template for no policy setting or only current user config are used.
    • Confirm that "404 Page not found" is not shown,

When a setting file does not exist, we unintentionally regarded the content
as "404 Page not found", but we should regard it as an empty setting.
@HashidaTKS HashidaTKS requested a review from piroor January 31, 2025 07:32
@piroor piroor merged commit e3e33eb into main Jan 31, 2025
1 check failed
@piroor
Copy link
Member

piroor commented Jan 31, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants