Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(5044/mvfsv): handle deleted feature states #5050

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jan 29, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add get_skip_create_audit_log on MultivariateFeatureStateValue to handle feature state delete
closes: #5044

How did you test this code?

Adds unit tests

@gagantrivedi gagantrivedi requested a review from a team as a code owner January 29, 2025 04:26
@gagantrivedi gagantrivedi requested review from matthewelwell and removed request for a team January 29, 2025 04:26
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 4:27am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 4:27am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 4:27am

@github-actions github-actions bot added the api Issue related to the REST API label Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5050 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5050 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5050 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5050 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5050 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5050 Finished ✅ Results

@github-actions github-actions bot added the fix label Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Uffizzi Preview deployment-60381 was deleted.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (ecd409b) to head (64b2c15).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5050   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files        1193     1193           
  Lines       41763    41792   +29     
=======================================
+ Hits        40678    40707   +29     
  Misses       1085     1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi merged commit b325998 into main Jan 29, 2025
36 checks passed
@gagantrivedi gagantrivedi deleted the fix/5044-mv-fsv branch January 29, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureState.DoesNotExist: FeatureState matching query does not exist.
2 participants