Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnloadConnectionScenes with UnloadUnused doesn't respect scenes that are loading #816

Open
FREEZX opened this issue Nov 14, 2024 · 2 comments
Labels
Acknowledged Your issue has been acknowledged and will be investigated. Resolved Pending Testing Issue has been resolved but requires further testing before being made available.

Comments

@FREEZX
Copy link
Contributor

FREEZX commented Nov 14, 2024

Important

General
Unity version: 2022.3.51
Fish-Networking version: 4.5.3
Discord link: https://discord.com/channels/424284635074134018/1296861541798514718/1306624506885836944

Description
If the server triggers an additive scene load for a connection, and then subsequently tries to call unload on the same scene for another connection before the first client loads it, the server will actually unload the scene

Replication
Steps to reproduce the behavior:

  1. ClientHost has some chunks loaded and is quickly moving to other chunks
  2. Client connects, requires the same chunks the ClientHost has already loaded
  3. ClientHost moves outside of these chunks, therefore it queues unload on these chunks for its own connection.
  4. RemoveOccupiedScenes does not remove the scenes as the client is not already in them, but is actually loading them
    So the ClientHost actually unloads these scenes, even though it should keep them for the newly connected client.

Expected behavior
Server actually keeps the scene that is being loaded on the first client.

@FirstGearGames FirstGearGames added the Acknowledged Your issue has been acknowledged and will be investigated. label Nov 16, 2024
@FirstGearGames
Copy link
Owner

Resolved pending testing in 4.5.6

@FirstGearGames FirstGearGames added the Resolved Pending Testing Issue has been resolved but requires further testing before being made available. label Nov 16, 2024
@FirstGearGames FirstGearGames removed the Resolved Pending Testing Issue has been resolved but requires further testing before being made available. label Dec 6, 2024
@FirstGearGames
Copy link
Owner

Resolved for individuals usage. Official fix is still in testing.

@FirstGearGames FirstGearGames added the Resolved Pending Testing Issue has been resolved but requires further testing before being made available. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Your issue has been acknowledged and will be investigated. Resolved Pending Testing Issue has been resolved but requires further testing before being made available.
Projects
None yet
Development

No branches or pull requests

2 participants