feat: throw warning if sbom is tagged internal #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Coverage Report •
|
italvi
changed the title
italvi
changed the title
github-actions
bot
added
the
documentation
italvi
requested changes
Jan 27, 2025
cdxev/build_public_bom.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def check_affected_metadata(metadata: dict[str, Any], path_to_schema: Path) -> bool: |
There was a problem hiding this comment.
Please use the already existing function, where it's checked for components instead of introducing a new function
cdxev/build_public_bom.py
Outdated
Comment on lines
39
to
40
| "Warning: `metadata.component` is not affected by the JSON schema!", | ||
| "Please check manually.", |
There was a problem hiding this comment.
The warning should be something like "metadata.component was not removed even though the JSON schema applies to it. Maybe you try to create an external SBOM for an internal component?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #224