Support setting the platform profile #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MithicSpirit
force-pushed
the
platform-profile
branch
2 times, most recently
from
a169ed5 to
525dc55
Compare
The platform profile lives in /sys/firmware/acpi/platform_profile. The desiredprof and defaultprof options correspond to the values for the platform profile set when gamescope begins and ends, respectively. HACK: The platform profile may restrict what values the governor can take, so we choose to set the governor before the platform profile in order to store the correct default governor, and restore the platform profile before the governor. This is done to maximize correctness after restoration, but it can cause issues if the previous platform profile restricts the governor. TODO: Save all the state we care about before any of it is changed. In thsi case, we should set (and restore) the platform profile before the governor.
Note that the platform profile feature is considered required. Maybe this shouldn't be the case, as I'm not sure how standard this feature is yet.
The platform profile may restrict what values the governor can take, so we need to save all state first to ensure the restored state is correct. Then, the platform profile is the first thing we set (and restore) to ensure all other changes are made to the best of our ability.
This reduces duplication of the split lock mitigation path. Additionally, it allows extending the functionality of procsysctl into also getting the split lock mitigation state.
MithicSpirit
force-pushed
the
platform-profile
branch
from
525dc55 to
badb27b
Compare
|
I was in the process of looking through this, and just saw that you made some further changes. |
I just forgot about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details.
This adds support for setting the platform profile via
/sys/firmware/acpi/platform_profile. It behaves very similarly to the governor, but with just one file.Note that setting the platform profile may change other options (like the governor) and prevent them from being altered further. Thus, this also necessitates a small refactor where the initial values are stored before any changes.
The tests for platform profile treat it as required (set the status to
-1if they fail). However, I'm not sure whether this should be the case, as I don't know how common this feature is yet.My nitpicking also got the best of me, so I extracted split lock mitigation stuff into
common-splitlock.c. For now, this really only matters for the path, but, in theory,procsysctlcould be altered to also allow getting the split lock mitigation state, rather than just setting it. Please let me know if this change is undesired, as I can just remove the last commit if so.Closes #516