add so easy pay gateway #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment so users of the API know what credentials they need to use and where to find those credentials. Figuring out the right credentials can be painful with E4 since they cut you off for 15 minutes if you get it wrong a few times. Hopefully these instructions will save folks some time. Closes activemerchant#589.
First Data e4: Fix remote test
http://www.evocanada.com/ Supports credit card and check purchases, and all of EVO's API methods. Closes activemerchant#585.
Use the standard method for determining if the payment method is a check
… trying to get card brand
cybersource: Check that payment_method_or_reference is not a string before getting the card brand
The name on the CC is included elsewhere as "FirstName" and "LastName". Including both was causing some issues was causing some strange behaviour.
…dress." This reverts commit a4170d9.
…one 'name' in payflow_link
…ndicator-to-worldpay Add debitCreditIndicator to amount if included in options
…-fix Paypal deprecated name field fix.
…ess_with_optimal Submit shipping address with optimal payments
Add secure source to Gemfile
Orbital rejects fields that are too long with an error. So, presumably they don't mind if part of the address is clipped so they'll at least attempt to process it. The maximum lengths are in the gateway specification at http://rafeekphp.files.wordpress.com/2009/04/orbital-gateway-interface-specification-43.pdf.
Truncate address-related params before sending to Orbital
Previously reference transactions were only supported/recognized by purchase. This adds a remote test for them when using authorize, and just duplicates the pattern used by purchase to get them working.
The action condition was only checking for 'PreAuthCapture' and not factoring in the possible ByRecordNo suffix. Closes activemerchant#772.
…fund Refund full application fee if 'refund_application_fee' is set.
Switches to using the ActiveMerchant standard of passing in the token as the payment method rather than using a Hash. The CVV can still be passed via the options hash. The old method of passing in a Hash is deprecated. Also cleans up the error handling to be more robust. Closes activemerchant#715.
Add mapping of debug to 'LMI_SIM_MODE'. See description on http://wiki.wmtransfer.com/projects/webmoney/wiki/Web_Merchant_Interface#request Closes activemerchant#727.
By specifying a wiredump device, such as:
ActiveMerchant::Billing::LitleGateway.wiredump_device = File.open('/var/tmp/litle.log', 'w')
The device will now be properly passed to the LitleOnline gem for
logging.
The LitleOnline gem uses its own connection mechanism and the logging
hook will be available only in versions more recent than 8.15.
Testing Done: tested the integration with the Kill Bill Litle plugin
(see http://kill-bill.org).
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
Allow to pass a paypageRegistrationId in the store() call, instead of a credit card. Testing Done: tested the integration with the Kill Bill Litle plugin (see http://kill-bill.org). Signed-off-by: Pierre-Alexandre Meyer <[email protected]> Closes activemerchant#740.
It simplifies code if we have to render something back to payment service. We can write in our controllers code like this: render @notification.success_response Closes activemerchant#744.
Removed unnecessary code and whacked some duplication.
In particular, the #capture, #credit, and #void calls were inconsistent with the other gateways in ActiveMerchant in that they took additional parameters. It's important for the gateways to share the same interface and use the options hash for gateway specific stuff. Now we use the authorization to hold the pieces SecureNet needs for capture, credit, and void.
|
Needs tests writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison from upstream master Shopify:master...feature/so_easy_pay