Add basic architectury networking setup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ | |||
| "hexcasting.spell.book.{{ modid }}:signum": "Dum. Actn.", | |||
| "{{ modid }}.entry.dummy_spells": "Dummy Spells", | |||
| "{{ modid }}.entry.dummy_actions": "Dummy Actions", | |||
| "{{ modid }}.page.dummy_spells.congrats": "Accepts a player entity, tells them they are doing a good job.", | |||
| "{{ modid }}.page.dummy_spells.congrats": "Accepts a player entity, tells them they are doing a good job and makes them look up.", | |||
There was a problem hiding this comment.
Maybe we should actually take the opportunity to fix this text - doesn't OpCongrats operate directly on the caster?
There was a problem hiding this comment.
Fair point, it really does. That's my oversight in the implementation of the spell, though, because it accepts a player entity (to show an example of a mishap when an incorrect entity is passed) and was supposed to act on that entity. I will be fixing that, thank you for pointing the discrepancy out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Architectury allows to implement platform-abstract networking in a simple and elegant way, and the added example is intended to demonstrate this to addon developers that might be less familiar with the it, as well as provide an easily adaptable baseline setup.