ospfd: Prune duplicate next-hop when installing into zebra route table. #17906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceelindem
force-pushed
the
aceelindem/ospf-prune-dup-next-hops
branch
from
4795c87 to
8be264c
Compare
|
Does this PR close #17869? |
Yes - we discussed it in the Tuesday huddle and both Don and Mark thought it would be good to not send the duplicates to zebra. One question is whether the change warrants a separate topotest? I found that there was already a multicast test with duplicates. |
|
if there is already a test w/ duplicates then just add a extension to that test to see that the duplicates are not sent down? |
OSPF topotest to test OSPF next-hop pruning on installation into zebra routing table. Also fix multicast_pim_dr_nondr_test topotest which had a duplicate OSPF route in the results. Signed-off-by: Acee Lindem <[email protected]> X
Duplicate next-hops are maintained for OSPF inter-area and AS external routes in the OSPF routing table as long as they correspond to LSAs for different adverting routers. The intra-area route computation will not result in duplicate next-hops. Signed-off-by: Acee Lindem <[email protected]>
aceelindem
force-pushed
the
aceelindem/ospf-prune-dup-next-hops
branch
from
8be264c to
1c55cf2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: OSPF topotest for next-hop pruning