Fix missing phpstan-symfony

FLUX-SE · Nov 11, 2024 · 5d39a3c · 5d39a3c
1 parent 7bec3a1
commit 5d39a3c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/composer.json b/composer.json
@@ -44,7 +44,8 @@
         "spaze/phpstan-stripe": "^3.2",
         "nyholm/psr7": "^1.8",
         "mockery/mockery": "^1.6",
-        "phpstan/phpstan-mockery": "^1.1"
+        "phpstan/phpstan-mockery": "^1.1",
+        "phpstan/phpstan-symfony": "^1.4"
     },
     "suggest": {
         "sylius/shop-bundle": "Use the Sylius default front shop",

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -8,8 +8,6 @@ parameters:
         - tests/Behat
 
     ignoreErrors:
-        - message: '/Cannot call method scalarNode\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null\./'
-          path: src/DependencyInjection/Configuration.php
         - message: '/Method FluxSE\\SyliusStripePlugin\\Stripe\\HttpClient\\PsrClient::[^\(]+\(\) has parameter \$[^ ]+ with no value type specified in iterable type array\./'
           path: src/Stripe/HttpClient/PsrClient.php
         - message: '/Method FluxSE\\SyliusStripePlugin\\Stripe\\HttpClient\\PsrClient::[^\(]+\(\) return type has no value type specified in iterable type array\./'

diff --git a/src/DependencyInjection/FluxSESyliusStripeExtension.php b/src/DependencyInjection/FluxSESyliusStripeExtension.php
@@ -18,22 +18,19 @@ final class FluxSESyliusStripeExtension extends AbstractResourceExtension implem
     /** @psalm-suppress UnusedVariable */
     public function load(array $configs, ContainerBuilder $container): void
     {
-        $configuration = $this->getConfiguration([], $container);
-        assert(null !== $configuration, 'Configuration cannot be null.');
-
-        $configs = $this->processConfiguration($configuration, $configs);
+        $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
 
         $container->setParameter(
             'flux_se.sylius_stripe.line_item_image.imagine_filter',
-            $configs['line_item_image']['imagine_filter'],
+            $config['line_item_image']['imagine_filter'],
         );
         $container->setParameter(
             'flux_se.sylius_stripe.line_item_image.fallback_image',
-            $configs['line_item_image']['fallback_image'],
+            $config['line_item_image']['fallback_image'],
         );
         $container->setParameter(
             'flux_se.sylius_stripe.line_item_image.localhost_pattern',
-            $configs['line_item_image']['localhost_pattern'],
+            $config['line_item_image']['localhost_pattern'],
         );
 
         $loader = new YamlFileLoader($container, new FileLocator(__DIR__ . '/../../config'));