Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW2 Maya Bhat #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HW2 Maya Bhat #7

wants to merge 2 commits into from

Conversation

mbhat25
Copy link

@mbhat25 mbhat25 commented May 27, 2016

No description provided.

<h2>Just another blank template</h2>
<h1 id="logo">Relaxr</h1>
<h2 id="tagline">Get piece of mind with a single tap</h2>
<p id="getit"> Get It Now</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbhat25 This should either be an <a href="#"></a> and style it or a button tag. p tags are meant for text
🔨

@rmjames
Copy link

rmjames commented May 31, 2016

@mbhat25 came out looking well, however be mindful to take advantage of the cascade in css. Always try to have styles for the body, so that you page has some default styles that will inherit through out you document. So all you have to do now is over write and add styles when needed. Please make note of the corrections.

Also try to name your classes in relations to what is happening in your document. For example instead of #container4 it could have been called #signup . That name describes what is happening within that container.

@mbhat25
Copy link
Author

mbhat25 commented Jun 1, 2016

@rmjames Updated!

@rmjames
Copy link

rmjames commented Jun 2, 2016

@mbhat25 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants