Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to Maven Central repository #2

Merged
merged 36 commits into from
Nov 4, 2024
Merged

Publish to Maven Central repository #2

merged 36 commits into from
Nov 4, 2024

Conversation

dennisvang
Copy link
Collaborator

@dennisvang dennisvang commented Oct 25, 2024 •
edited
Loading

This PR implements publication to the Maven Central repository (fixes #3):

  • changed groupId from com.github.fairdevkit to org.fairdatateam.rdf
  • changed package namespace (and corresponding paths) from com.github.fairdevkit to org.fairdatateam.rdf for consistency
  • separated build/test workflow from publication workflow
  • simplified and upgraded workflows
  • configured pom and workflows for publication to Maven Central Portal
  • bumped minor version to 0.2.0

QUESTIONS:

  • Actually the modified namespace is a breaking change, because dependent projects need to update their pom and imports. Given that the package has been in "production" use for some time, perhaps it would be better to bump to 1.0.0?

TODO:

  • enable issue tracking in upstream
  • configure upstream repository secrets (GPG key, central portal access token)

@dennisvang
change groupId from fairdevkit to fairdatateam
6fffb88 
see e.g. https://maven.apache.org/repository/guide-central-repository-upload.html#faq-and-common-mistakes
@dennisvang
rename fairdevkit subfolder to fairdatateam
9696e56 
to match groupId
@dennisvang
remove nexus deployment from ci.yml workflow
e7d2543 
and adapt worflow with
  - explicit temurin distribution
  - java version matrix (temurin LTS versions)
  - latest versions of actions (v4)
@dennisvang
add maven-publish workflow
964213d 
and rename ci.yml to maven-ci.yml for consistency
@dennisvang
tidy poms
964c3f3
@dennisvang
switch pom distributionManagement repo back to github packages
44034e7 
temporarily using dennisvang account for dev convenience
@dennisvang
replace shorthand mvn options in workflows by verbose options
4944b4f
@dennisvang
DRY project version
56ca12e 
using `revision` property, as defined in [maven docs][1]

[1]: https://maven.apache.org/maven-ci-friendly.html#multi-module-setup
@dennisvang
add flatten-maven-plugin to parent pom
3cf544b 
required when using project versioning based on `revision` property, as in [CI friendly versions][1]

[1]: https://maven.apache.org/maven-ci-friendly.html#install-deploy
@dennisvang
gitignore .flattened-pom.xml files generated by flatten-maven-plugin
f9e5af6
@dennisvang
tidy pom...
d32bbcc
@dennisvang
fix temporary repo url in pom
979fe7b
@dennisvang
generic Maven repository url based on environment variable
8a1060c 
using [default environment variable][1] `GITHUB_REPOSITORY`

[1]: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
@dennisvang
explicit version for flatten-maven-plugin
d74606d
@dennisvang
simplify maven-ci workflow using setup-java cache
78010f7
@dennisvang
rename packages according to org.fairdatateam namespace
4604835
@dennisvang
DRY groupId and artifactId in pom files
01afd70
@dennisvang
add pom plugins for publishing, javadoc, sources, and gpg
d626b89
@dennisvang
simplify maven-gpg-plugin config in pom
9075ef9 
this is a test, because docs are conflicting w.r.t. the need for --pinentry-mode etc.
@dennisvang
add gpg variables to maven-ci workflow
ade17c3
@dennisvang
add scm, developers, name, description, and url to pom
b1da66f 
as required for publication to maven central
@dennisvang
adapt maven-publish workflow to use maven central portal
ccb149f
@dennisvang
remove workflow permissions and use server-id maven
28a31c4
@dennisvang
use mvn batch mode in publish workflow
ffd1b69
@dennisvang
revert workflow server-id to central
ad8201c
@dennisvang
override groupId using env var in workflow
9bbff86
@dennisvang
remove -SNAPSHOT from version and bump to 0.1.3dev0
d951924
@dennisvang
fix typo in workflow
c4dac50
@dennisvang
hardcode groupid for fork
62862a7 
trying to debug the maven central validation process
@dennisvang
note about maven central validation
0d15eeb
@dennisvang
remove dry groupid and artifactid
789a46e 
because this may complicate publication
@dennisvang
update changelog
dd52fb3
@dennisvang
fix orphan groupid reference
251931f
@dennisvang
bump version to 0.2.0dev0
fa2638b 
the changes are backward incompatible, but we are still in major 0, so we only increment minor
@dennisvang
change groupId to org.fairdatateam.rdf, hardcode github repo url, and…
de311f3 
… remove version modifier

Use hardcoded urls because variables are not expanded during publication, resulting in broken urls in package metadata on maven central.
@dennisvang
skip GPG signing in maven-ci workflow
188e93a 
Signing is only required in maven-publish. Moreover, it causes the maven-ci workflow to fail if triggered by PR from fork, because I does not have access to github secrets.
@dennisvang dennisvang marked this pull request as ready for review October 28, 2024 16:45
@dennisvang
Copy link
Collaborator Author

Please squash merge.

@dennisvang dennisvang mentioned this pull request Oct 28, 2024
Merged
4 tasks
@luizbonino luizbonino merged commit 9ee2669 into FAIRDataTeam:develop Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizbonino luizbonino luizbonino approved these changes

@kburger kburger Awaiting requested review from kburger

@MarekSuchanek MarekSuchanek Awaiting requested review from MarekSuchanek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish to Github Packages or Maven Central repository
2 participants
@dennisvang @luizbonino