Dojo: Replicate Action Refactor #304
Conversation
…plateUseCase and ReplicateFromTableUseCase stub
…teUseCase and spec
…mportTable to the replicate function.
…rsError function.
…ove unused props in ReplicateUserFromTable.
|
@xurxodev putting on draft to remove the demo part from the PR |
…FromTemplate final-form version only
…e $index validation, now its correctly translated as the replicate count.
There was a problem hiding this comment.
thanks @nshandra
I've found issues to review:
- Non related specially to this PR but UserLogic is really the entity and User is the props. I would expect the names as UserLogic -> User and User -> UserProps
- In the new code affected by this PR that to use UserRepository, we should change to return the entity from the repository and not the props.
I've added rest of the issues in comments in the code.
| @@ -152,6 +152,22 @@ export class UserD2ApiRepository implements UserRepository { | |||
| ).map(({ objects }) => objects.map(user => user.id)); | |||
| } | |||
|
|
|||
| public listAllUsernames(options: ListOptions): FutureData<string[]> { | |||
There was a problem hiding this comment.
A repository should never return primitive types, this is a code smell that we saw in the coding dojo
In Clean Architecture, a repository should always return entities.
The presentation layer should map user list to get userNames if required.
In this case the entity is UserLogic (can we change to User and User to UserProps?)
| @@ -0,0 +1,11 @@ | |||
| import { UseCase } from "../../CompositionRoot"; | |||
There was a problem hiding this comment.
A use case should never return primitive types, this is a code smell that we saw in the coding dojo
In Clean Architecture, a use case should always return entities.
The presentation layer should map user list to get userNames if required.
In this case the entity is UserLogic (can we change to User and User to UserProps?)
| @@ -597,14 +630,23 @@ const useValidations = ( | |||
| return { | |||
| validation: (value: string) => { | |||
| if (!value) return i18n.t("Please provide a username"); | |||
| if (/^[._@-]|[._@-]$/.test(value)) { | |||
There was a problem hiding this comment.
These new validations are business rules validations and should be realized in the user domain entity
| } | ||
|
|
||
| export const ReplicateUserFromTable: React.FC<ReplicateUserFromTableProps> = props => { | ||
| const { compositionRoot } = useAppContext(); |
There was a problem hiding this comment.
The component should only render. (render logic)
The rest of the presentation logic (manage state, actions, invoke use cases, etc.) should be in a custom hook: useReplicateUserFromTable.
In this custom hook, we should use the user entity, not the user props
| onRequestClose: () => void; | ||
| } | ||
|
|
||
| export const ReplicateUserFromTemplate: React.FC<ReplicateUserFromTemplateProps> = props => { |
There was a problem hiding this comment.
The rest of the presentation logic (manage state, actions, invoke use cases, etc.) should be in a custom hook: useReplicateUserFromTemplate.
In this custom hook, we should use the user entity, not the user props
| </> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
These validations are business rules validations and should be realized in the user domain entity.
To validate you can to try to create a domain entity, call internally to validate a return, for example an Either with the entity or the errors.
You can see these examples:
📌 References
📝 Implementation
Refactor replicate functions: