Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleted sections on migrations executed #37

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

p3rcypj
Copy link
Contributor

@p3rcypj p3rcypj commented Jun 24, 2024

📌 References

📝 Implementation

The issue was the bad use of the collection to find wether a node has its parent in the same collection.

  • Previously: the accumulator while iterating the tree.
  • Now: the tree itself.

🔥 Testing

docker.eyeseetea.com/eyeseetea/dhis2-data:2.36.11.1-sp-ip-pro
docker.eyeseetea.com/samaritans/dhis2-data:40.3.0-sp-ip-dev

@p3rcypj p3rcypj requested a review from adrianq June 24, 2024 09:13
@p3rcypj p3rcypj marked this pull request as ready for review June 24, 2024 09:47
@adrianq adrianq merged commit 99ab1bc into development Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants