Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set complete status before moving to step 4 #315

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

set complete status before moving to step 4 #315

wants to merge 2 commits into from
+89 −76

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Jan 12, 2025 •
edited
Loading

📌 References

📝 Implementation

  1. Wait for get specific data submission to be fetched before loading page.
  2. The get specific data submission hook was using promises, refactored to use futures.
  3. Change from step 3 (Review data summary) to step 4 (completion screen) only after updating the data submission status to "COMPLETE" (Data to be approved by country)

📹 Screenshots/Screen capture

CompleteStatusFix.mov

🔥 Testing

.

@ifoche
Copy link
Member

ifoche commented Jan 12, 2025

Task linked: CU-8697c0fnf EGASP : Now URGENT! Files uploaded correctly but submission status not changed

@9sneha-n 9sneha-n marked this pull request as ready for review January 12, 2025 19:18
anagperal
anagperal approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@anagperal anagperal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagperal anagperal anagperal approved these changes

@bhavananarayanan bhavananarayanan Awaiting requested review from bhavananarayanan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9sneha-n @ifoche @anagperal