-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize all parts (molstar, viewer, protvista) by AUTH chainId instead of STRUCT asymId #238
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In-line comments:
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/data/repositories/BionotesPdbInfoRepository.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/dropdown/Dropdown.tsx
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/usePluginRef.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/usePluginRef.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/usePluginRef.ts
Show resolved
Hide resolved
app/assets/javascripts/3dbio_viewer/src/webapp/components/molecular-structure/usePluginRef.ts
Outdated
Show resolved
Hide resolved
I rewrote most of the responsibilities on usePluginRef, I hope now it makes more sense by reading it. Abstracting it into smaller functions was a really good point because it made me review all the scenarios again several times and when the code was really executed I ended up removing unnecessary code. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, code-wise 👍
📌 References
📝 Implementation