Skip to content

Commit

Permalink
missing version args
Browse files Browse the repository at this point in the history
  • Loading branch information
Rikard Gynnerstedt (BN) authored and Rikard Gynnerstedt (BN) committed Aug 21, 2020
1 parent 46e5901 commit fedadb6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
asset_name: cloudmonitor_exporter_${{ steps.vars.outputs.tag }}_windows_amd64.tar.gz
asset_content_type: application/gzip
- name: Build Image
run: make docker
run: VERSION=${{ steps.vars.outputs.tag }} make docker
- name: Login to docker hub
run: docker login --username ${{ secrets.DOCKERHUB_USERNAME }} --password ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Push to docker hub
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ rpm: package
docker run --rm -i -v $(shell pwd):/docker centos:7 /docker/package/rpm/build_rpm.sh ${VERSION}

docker: xbuild
docker build --build-arg version=${VERSION} . -t cloudmonitor_exporter:${VERSION}
docker build --build-arg version=${VERSION} . -t bonniernews/cloudmonitor_exporter:${VERSION}

0 comments on commit fedadb6

Please sign in to comment.