Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update snapshot assignment to merge existing values instead of ov… #593

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/Onyx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ function updateSnapshots(data: OnyxUpdate[]) {
return;
}

let updatedData = {};
let updatedData: Record<string, unknown> = {};

data.forEach(({key, value}) => {
// snapshots are normal keys so we want to skip update if they are written to Onyx
Expand All @@ -573,7 +573,10 @@ function updateSnapshots(data: OnyxUpdate[]) {
return;
}

updatedData = {...updatedData, [key]: lodashPick(value, Object.keys(snapshotData[key]))};
const oldValue = updatedData[key] || {};
const newValue = lodashPick(value, Object.keys(snapshotData[key]));

updatedData = {...updatedData, [key]: Object.assign(oldValue, newValue)};
});

// Skip the update if there's no data to be merged
Expand Down
Loading