Fix race condition when tempState is deleted before loading flag is set to false

[ospfranco]

Details

There is a small race condition. When calling setWithOnyxState we delete the tempState object that is used to hold temporary state updates while the HOC is gathering data. However the loading flag is only set on the setState callback down below. setState however is an async operation that is also batched, therefore there is a small window of time where the loading flag is not false but the tempState is already gone (while the update is queued and waiting to be applied). This simply bypasses the loading check if the tempState is gone and the update can be safely queued with a normal setStateProxy.

Related Issues

GH_LINK Expensify/App#28419

Automated Tests

Linked PRs

[mountiny]

Thanks! This looks good but I ma not fan of the line numbers in the comment, that will inevitably change and become out of date. Could you please rewrite it without the numbers

[mountiny]

Thanks!

[getusha]

@mountiny we were also attempting to get this change merged here #368 😄, anyway thanks for handling it.

[mountiny]

Ah yeah, saw that, this was faster for our purposes :D