Revert back to Storage.clear() in Onyx.clear() instead of removeItems(). Abort the setItem() queue.
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree with the evaluation that guides signing in + out is higher priority than multi-tab edge cases. |
|
I'm going to close this and leave all the context I have in an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a kind of soft revert of the changes here -> #237
I am not removing the
removeItems()code yet until we know why it doesn't work.For now, this will re-introduce the bug here: Expensify/App#15321
I'm not sure why the issue is open and haven't really caught up on it so maybe @roryabraham has more context.
Regardless, having Guides be able to cleanly log out of their accounts seems higher value.
Related Issues
Expensify/App#21766
Automated Tests
❌
Linked PRs
TBD