Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use legacy worker for prev. IOS #43

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rezkiy37
Copy link
Contributor

@rezkiy37 rezkiy37 commented Jan 15, 2025

Details

A bug was detected in the previous IOS version - 17.x. Unfortunately, the latest PDF.js worker does not render files. I am returning the legacy one.

Related Issues

Expensify/App#55176

Manual Tests

  1. Launch the example app.
  2. Open an example PDF file.
  3. Verify that there are no warnings in the console and that the file is displayed properly.
Screenshots

legacy

Linked PRs

Revert - #39, #40

@rezkiy37 rezkiy37 marked this pull request as ready for review January 16, 2025 14:09
@rezkiy37 rezkiy37 changed the title [WIP] Use legacy worker for prev. IOS Use legacy worker for prev. IOS Jan 16, 2025
@mountiny
Copy link
Contributor

@gedu did you see this?

@gedu
Copy link

gedu commented Jan 16, 2025

is it an issue from iOS? why last pdf is not supported?

Copy link

@jjcoffee jjcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rezkiy37
Copy link
Contributor Author

rezkiy37 commented Jan 17, 2025

is it an issue from iOS? why last pdf is not supported?

I guess the latest PDF.js worker does not support the previous IOS Safari. It is an excellent point. I think we need to make a sort of hot fix right now and return the legacy worker, but I am going to investigate and apply the current worker as the next step.

@mountiny mountiny merged commit 27427a4 into Expensify:main Jan 17, 2025
2 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Jan 17, 2025

🚀 Published to npm in 1.0.22 🎉

@rezkiy37 rezkiy37 mentioned this pull request Jan 20, 2025
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants