Upgrade versions and fix example #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezkiy37
changed the title
8 tasks
|
@rezkiy37 Should I test this against the Expensify app too? |
|
@jjcoffee yeah, a good point. I've tried to test both projects locally but unfortunately, react-fast-pdf cannot use a couple of dependencies. I imported |
|
@rezkiy37 Okay that makes sense, thanks! |
|
@mountiny, this one it ready to go 🙂 |
mountiny
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The PR upgrades versions of
"react-pdf": "^9.2.1"and"react-window ^1.8.11".Details
Also, it locks
pdfjs-distto4.8.69as react-pdf utilizes.Related Issues
Expensify/App#55176
Manual Tests
Screenshots
Linked PRs