Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resetSMSDeliveryFailureStatus command #825

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Add resetSMSDeliveryFailureStatus command #825

merged 1 commit into from
Dec 26, 2024

Conversation

carlosmiceli
Copy link
Contributor

Just a missing command so the already deployed code for resetting SMS delivery failure status in Web-E can work as expected :)

Fixed Issues

https://github.com/Expensify/Expensify/issues/335408

Tests

Same as https://github.com/Expensify/Web-Expensify/pull/44736

QA
Same as https://github.com/Expensify/Web-Expensify/pull/44736

@carlosmiceli carlosmiceli requested a review from a team as a code owner December 26, 2024 17:49
@carlosmiceli carlosmiceli self-assigned this Dec 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@melvin-bot melvin-bot bot requested review from puneetlath and removed request for a team December 26, 2024 17:49
@carlosmiceli
Copy link
Contributor Author

recheck

@carlosmiceli
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Dec 26, 2024
@CLABotify
@carlosmiceli has signed the CLA in Expensify/expensify-common#825
3541482
@rlinoz rlinoz merged commit acb6856 into main Dec 26, 2024
6 checks passed
@rlinoz rlinoz deleted the cm-add-sms-delivery-command branch December 26, 2024 18:02
@os-botify
Copy link
Contributor

os-botify bot commented Dec 26, 2024

🚀 Published to npm in 2.0.111 🎉

techievivek added a commit that referenced this pull request Dec 27, 2024
@techievivek
Revert "Merge pull request #825 from Expensify/cm-add-sms-delivery-co…
81ef715 
…mmand"

This reverts commit acb6856, reversing
changes made to 67c905c.
Beamanator added a commit that referenced this pull request Dec 27, 2024
@Beamanator
Merge pull request #826 from Expensify/techievivek_revert_changes_for…
3aafb41 
…_resetsmsdeliveryfailure

Revert "Merge pull request #825 from Expensify/cm-add-sms-delivery-command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlinoz rlinoz rlinoz approved these changes

@techievivek techievivek Awaiting requested review from techievivek

@puneetlath puneetlath Awaiting requested review from puneetlath

Assignees

@carlosmiceli carlosmiceli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosmiceli @rlinoz