Add support for nested quotes #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
robertKozik
changed the title
melvin-bot
bot
requested review from
blimpich
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for nested quotes. Maximal level of quotes is set to 3.
Additionally it fixes bug with double removal of
>symbolFixed Issues
$ Expensify/App#36227
Tests
Every test involving writing messages with quotes will be relevant in this case, as the behaviour of single quotes shouldn't be changed. In addition, every such a test can be tweaked to check nested quotes case simply by adding additional
>symbolI've checked it by running all unit tests and by linking it in E/App and checking in chat itself
I'm going to add additional unit tests which should be sufficient to cover all popular cases. Morove manual testing inside E/App.
QA
Typing any message with multiple quotes (f.e
> > > Hello world)Chat/Quotes
Anything regarding quotes should be tested, as quite big chunk of code regarding quotes were changed here